Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue when navigating the sidebar using the tab key #16277

Merged

Conversation

priadiliav
Copy link
Contributor

Resolved / Related Issues

Note: The solution to the issue was a simple change: setting the IsTabStop attribute to False. This was necessary as we were excluding focus from each selected element.

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files
  2. Press "Tab" (You can see focused element)
  3. Use the 'Down' and 'Up' arrow keys (you won't be able to see the focused element, but it will change. When you press 'Tab' again, you will see the border on the element where the focus is. If you try to move to the next element, it will change, but without a visible border)."

@priadiliav priadiliav changed the title Fis: Fixed: Focus indicator not displayed when navigating in the sidebar using keyboard Sep 29, 2024
@yaira2
Copy link
Member

yaira2 commented Sep 29, 2024

Is ElementGrid still a tab stop? We should confirm that only one element is a top stop.

@priadiliav
Copy link
Contributor Author

priadiliav commented Sep 29, 2024

Honestly, I'm not entirely sure I understood the question, but i recorded a video to demonstrate it.

Network.2.-.Files.2024-09-30.00-11-06.mp4

@yaira2
Copy link
Member

yaira2 commented Sep 29, 2024

The border contains a grid, we need to confirm that only one of the elements is treated as a tab stop.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 1, 2024
@yaira2 yaira2 changed the title Fixed: Focus indicator not displayed when navigating in the sidebar using keyboard Fix: Fixed an issue when navigating the sidebar with the tab key Oct 1, 2024
@yaira2 yaira2 merged commit 239f4bc into files-community:main Oct 1, 2024
6 checks passed
@yaira2 yaira2 changed the title Fix: Fixed an issue when navigating the sidebar with the tab key Fix: Fixed an issue when navigating the sidebar using the tab key Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Focus indicator not displayed when navigating in the sidebar using keyboard
2 participants