-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Added empty projects for Files.App.Controls and Files.App.UITests #15784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Have no idea why the files added all those extra lines. I tried removing things with Configuration Manager, but I was getting confused about all the changes. Thank you for making the changes you did |
Yeah .sln file is completely mess but lately VS preview made a new format .slnx with xml format: <Solution>
<Project Path=“src/Files.App/Files.App” />
</Solution> |
So it wasn't a mistake on my part then? |
Yeah, every time I add a project they make extra configurations. |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.