Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Added empty projects for Files.App.Controls and Files.App.UITests #15784

Merged
merged 17 commits into from
Jul 14, 2024

Conversation

mdtauk
Copy link
Contributor

@mdtauk mdtauk commented Jul 10, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files ...
  2. ...

Files.sln Outdated Show resolved Hide resolved
tests/Files.App.UITests/Package.appxmanifest Outdated Show resolved Hide resolved
Files.sln Outdated Show resolved Hide resolved
Files.sln Outdated Show resolved Hide resolved
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mdtauk
Copy link
Contributor Author

mdtauk commented Jul 10, 2024

Have no idea why the files added all those extra lines. I tried removing things with Configuration Manager, but I was getting confused about all the changes. Thank you for making the changes you did

@0x5bfa
Copy link
Member

0x5bfa commented Jul 10, 2024

Yeah .sln file is completely mess but lately VS preview made a new format .slnx with xml format:
I’m looking forward to his format and hopefully we’ll get this in the stable in this summer.
I’m not sure why they’ve kept this format even after vs2022.
https://blog.ndepend.com/slnx-the-new-net-solution-xml-file-format/

<Solution>
    <Project Path=“src/Files.App/Files.App” />
</Solution>

@mdtauk
Copy link
Contributor Author

mdtauk commented Jul 10, 2024

Yeah .sln file is completely mess but lately VS preview made a new format .slnx with xml format: I’m looking forward to his format and hopefully we’ll get this in the stable in this summer. I’m not sure why they’ve kept this format even after vs2022. https://blog.ndepend.com/slnx-the-new-net-solution-xml-file-format/

<Solution>
    <Project Path=“src/Files.App/Files.App” />
</Solution>

So it wasn't a mistake on my part then?

@0x5bfa
Copy link
Member

0x5bfa commented Jul 10, 2024

Yeah, every time I add a project they make extra configurations.

@yaira2 yaira2 requested a review from marcelwgn July 10, 2024 15:22
@yaira2 yaira2 merged commit de0328e into files-community:main Jul 14, 2024
6 checks passed
@mdtauk mdtauk deleted the mdta-empty-projects branch July 14, 2024 02:26
@mdtauk mdtauk restored the mdta-empty-projects branch July 14, 2024 02:29
@mdtauk mdtauk deleted the mdta-empty-projects branch August 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants