Fix: Fixed an issue with Nutstore cloud drive detection #15445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangfu91
changed the title
yaira2
changed the title
yaira2
changed the title
|
Fyi @hecksmosis |
yaira2
approved these changes
May 22, 2024
|
@wangfu91 thank you for the fix! While you're here, are there any other integrations that we can do with Nutestore to improve the experience (eg. context menu options etc)? |
yaira2
added
ready to merge
|
Thanks for merging my PR @yaira2, kudos for building such a beautiful app.
Files have already properly integrated the context menu, I haven't found anything else to improve at the moment, I will raise an issue or create a PR if I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm a developer at the company Nutstore, I've found out that the cloud drive detection logic for Nutstore in PR #10890 is incorrect.
Searching all the sub-directories named "Nutstore" in
%userprofile%can be extremely time-consuming and will likely cause the Files app the stop responding, it may also result in multiple incorrect Nutstore cloud drive entries.Querying the registry entries in
SyncRootManageris a more efficient way to detect the root dir of the Nutstore cloud drive.