Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prompt for credentials when a network share access is denied #14904

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

nmangue
Copy link
Contributor

@nmangue nmangue commented Mar 5, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Unable to access administrative shares #14903

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Launch Files with a low-privileged user account
    2. Access a server adminsitrative share (\myserver\c$)

Screenshots (optional)
Capture d’écran 2024-03-05 103721

@Josh65-2201 Josh65-2201 changed the title Prompt for credentials when a network share access is denied Fix: Prompt for credentials when a network share access is denied Mar 5, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 5, 2024
@yaira2
Copy link
Member

yaira2 commented Mar 5, 2024

Congrats on your first PR to Files!

@yaira2 yaira2 merged commit a83507e into files-community:main Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to access administrative shares
2 participants