Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Remove thumbnail cache to simplify logic and improve performance #14871

Merged
merged 12 commits into from
Mar 3, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 29, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Ya/icons op Code Quality: Only call thumbnail loop for cloud files Feb 29, 2024
src/Files.App/Data/Models/ItemViewModel.cs Outdated Show resolved Hide resolved
src/Files.App/Data/Models/ItemViewModel.cs Outdated Show resolved Hide resolved
src/Files.App/Data/Models/ItemViewModel.cs Outdated Show resolved Hide resolved
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of code quality

@yaira2 yaira2 force-pushed the ya/IconsOp branch 2 times, most recently from b686e6d to 68bd772 Compare March 1, 2024 18:33
@yaira2 yaira2 changed the title Code Quality: Only call thumbnail loop for cloud files Code Quality: Remove thumbnail cache to simplify logic and improve performance Mar 3, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 3, 2024
@yaira2 yaira2 merged commit 4f4cd89 into main Mar 3, 2024
5 checks passed
@yaira2 yaira2 deleted the ya/IconsOp branch March 3, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants