Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Renamed "Favorites" section to "Pinned" #14862

Merged

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Feb 28, 2024

Summary

  • Replaced all "Favorite" & "favorite" entities.
  • No "Favourites" & "favourite" entity found.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Launch the app
    2. See the sidebar and "Pinned" string is shown

Screenshots

None

docs/rich-commands.md Outdated Show resolved Hide resolved
@yaira2 yaira2 changed the title Feature: Renamed "Favorites" with "Pinned" Feature: Renamed "Favorites" section to "Pinned" Feb 28, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 28, 2024
@yaira2 yaira2 merged commit 23eafb1 into files-community:main Feb 28, 2024
5 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Rename-SidebarFavoritesWithPinned branch February 29, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants