Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where tabs weren't restored when resuming from the background #14857

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 27, 2024

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 assigned yaira2 and unassigned yaira2 Feb 27, 2024
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 28, 2024
@yaira2 yaira2 merged commit 3e8f60f into main Feb 28, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/FixResuming branch February 28, 2024 02:44
@yaira2
Copy link
Member Author

yaira2 commented Mar 1, 2024

We also need to consider the case where the path changes. At this point it might be worth splitting the tab list into its own file to avoid the need to reserialize settings every time the location changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Continue where you left off is missed up when resuming from the background
2 participants