Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add icon sizes to the layout flyout #14834

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Feature: Add icon sizes to the layout flyout #14834

merged 1 commit into from
Feb 26, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 26, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM codebase-wise.
It's worth it to make a UserControl for this flyout, instead?

@yaira2
Copy link
Member Author

yaira2 commented Feb 26, 2024

It's worth it to make a UserControl for this flyout, instead?

Probably, or at least separate the xaml from the toolbar. Would you like to work on this after merging the PR?

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 26, 2024
@yaira2 yaira2 merged commit a806f45 into main Feb 26, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/AddIcons branch February 26, 2024 15:43
@0x5bfa
Copy link
Member

0x5bfa commented Feb 26, 2024

Probably, or at least separate the xaml from the toolbar. Would you like to work on this after merging the PR?

Everything is welcome. Yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants