Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Improve icon code for recent items #14805

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 21, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirm Recent Item icons load correctly

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 merged commit fc2c2cd into main Feb 21, 2024
5 checks passed
@yaira2 yaira2 deleted the ya/RecentItemIcon branch February 21, 2024 19:12
@0x5bfa 0x5bfa added the ready to merge Pull requests that are approved and ready to merge label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants