Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where item selection didn't work properly the List View layout #14800

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix: Fixed issue where item selection didn't work properly the List View layout #14800

merged 3 commits into from
Feb 21, 2024

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Clicking on an empty space sometimes fails to deselect items #14785

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu marked this pull request as draft February 21, 2024 14:14
@hishitetsu hishitetsu marked this pull request as ready for review February 21, 2024 15:07
yaira2
yaira2 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit d7349ec into files-community:main Feb 21, 2024
6 checks passed
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 21, 2024
@yaira2 yaira2 changed the title Fix: Fixed issue where item selection couldn't work properly in List layout Fix: Fixed issue where item selection didn't work properly in List layout Feb 21, 2024
@yaira2 yaira2 changed the title Fix: Fixed issue where item selection didn't work properly in List layout Fix: Fixed issue where item selection didn't work properly the List View layout Feb 21, 2024
@hishitetsu hishitetsu deleted the FixListView branch February 23, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Clicking on an empty space sometimes fails to deselect items
2 participants
@hishitetsu @yaira2