Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Restore tabs when Files process is closed incorrectly #14795

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Feature: Restore tabs when Files process is closed incorrectly #14795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Files.App/Data/Contexts/Multitasking/MultitaskingContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public MultitaskingContext()
private void AppInstances_CollectionChanged(object? sender, NotifyCollectionChangedEventArgs e)
{
UpdateTabCount();
AppLifecycleHelper.SaveSessionTabs();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete any other code that calls SaveSessionTabs()?

Copy link
Member Author

@yaira2 yaira2 Feb 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They might be worth keeping because AppInstances_CollectionChanged is only called when a tab is added/removed, it's fine for a single instance but it can cause issues with multiple windows. That said, if we add support for saving the tab list for multiple windows, I think we can rely on this one call.

}
private void AppModel_PropertyChanged(object? sender, PropertyChangedEventArgs e)
{
Expand Down
Loading