Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Added default icon sizes to LayoutSettingsService #14645

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Feb 4, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Slider to control thumbnail size #10492

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Switch to Grid View
    2. Change icon size (ctrl + +/-)
    3. Navigate to a different folder and then back to the original folder
    4. Confirm the custom size is used

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 merged commit 2170976 into main Feb 5, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/IconSizes branch February 5, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant