Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Refactor context flyout helpers 1 #14609

Merged

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Feb 1, 2024

Summary

  • Renamed classes
  • Format codebase

PR Checklist

  • Development: N/A
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

yaira2
yaira2 previously approved these changes Feb 1, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 1, 2024
yaira2
yaira2 previously approved these changes Feb 1, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 1, 2024

OMG, XAML reference...

@yaira2 yaira2 merged commit 4f8aebf into files-community:main Feb 2, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Improve-ContextFlyoutModel2 branch February 13, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants