Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where placeholders used the thumbnail instead of the icon #14607

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Fix: Fixed issue where placeholders used the thumbnail instead of the icon #14607

merged 3 commits into from
Feb 1, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 31, 2024 •
edited
Loading

Resolved / Related Issues

  • This fixes an issue where placeholders for Office Documents and other file formats were created based on the thumbnail instead of the icon.
  • This PR also adds placeholders for images files

@yaira2 yaira2 marked this pull request as draft January 31, 2024 22:00
@yaira2 yaira2 changed the title Feature: Display placeholders for all file formats Feature: Display placeholders for all file extensions Jan 31, 2024
@yaira2 yaira2 added help wanted Extra attention is needed needs - code review labels Jan 31, 2024
@yaira2 yaira2 changed the title Feature: Display placeholders for all file extensions Fix: Fixed issue where file placeholders were based on the thumbnail Jan 31, 2024
@yaira2 yaira2 removed the help wanted Extra attention is needed label Jan 31, 2024
@yaira2 yaira2 marked this pull request as ready for review January 31, 2024 22:48
@yaira2 yaira2 changed the title Fix: Fixed issue where file placeholders were based on the thumbnail Fix: Fixed issue where placeholders used the thumbnail instead of the icon Jan 31, 2024
hishitetsu
hishitetsu approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 1, 2024
@yaira2 yaira2 merged commit 681b2d3 into main Feb 1, 2024
5 checks passed
@yaira2 yaira2 deleted the ya/Placeholders branch February 1, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @hishitetsu