Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the privacy policy link was broken #14584

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jan 30, 2024

Summary

As the title.

Steps To Validate Changes

  1. Launch the app
  2. Go to Settings
  3. Go to About page
  4. Click the link button

PR Checklist

  • Development: Closes Bug: Privacy Link Doesn't Open Privacy Policy #14583
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@yaira2 yaira2 changed the title Fix: Fixed an issue where the in-app privacy policy link didn't navigate the right page Fix: Fixed issue where the privacy policy link was broken Jan 30, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 30, 2024
@yaira2 yaira2 merged commit 1b836b2 into files-community:main Jan 30, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Fix-InAppPrivaryLink branch January 30, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Privacy Link Doesn't Open Privacy Policy
2 participants