Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed potential crash when opening properties for recent files #14535

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 23, 2024

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open file from removable storage device
    2. Eject the storage device
    3. Right click the recent file and try opening properties
    4. Confirm that an error prompt is displayed

Screenshots (optional)
Add screenshots here.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 24, 2024
@yaira2 yaira2 merged commit ee80ce7 into main Jan 24, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/FixCrashForDeletedItem branch January 24, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Crash when opening properties of a deleted file from "Recent Files"
2 participants