Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added a List View layout #14489

Merged
merged 10 commits into from
Jan 22, 2024

Conversation

marcelwgn
Copy link
Contributor

@marcelwgn marcelwgn commented Jan 18, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Add a list layout #2509...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
    • Removed border from selected items in the Grid View layouts
  • Are there any other steps that were used to validate these changes?
    1. Switch to List View using the toolbar flyout, context menu, ctrl + shift + 2 shortcut
    2. Switch from the Details View to List View using ctrl + + and from the Grid View using ctrl + -
    3. Set the default view to List and confirm it works as expected
    4. Enable compact spacing and confirm it works as expected
    5. Rename items in the List View and confirm it works as expected

Screenshots (optional)
image

@yaira2 yaira2 force-pushed the dev/vertical-list-columns branch 5 times, most recently from aa60efc to 4f2725a Compare January 18, 2024 22:58
@yaira2 yaira2 force-pushed the dev/vertical-list-columns branch from 7ea8ebe to 11d239a Compare January 18, 2024 23:06
@yaira2 yaira2 changed the title [DRAFT] Implement File Explorer like vertical columns Feature: Added a List View layout Jan 21, 2024
@yaira2 yaira2 marked this pull request as ready for review January 21, 2024 18:27
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works fine and I haven't been able to break the feature in any major way.

src/Files.App/Actions/Display/LayoutAction.cs Show resolved Hide resolved
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 22, 2024
@yaira2 yaira2 merged commit d550d3e into files-community:main Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add a list layout
3 participants