-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed issue where the Properties window had the wrong icon #14470
Merged
yaira2
merged 6 commits into
files-community:main
from
0x5bfa:5bfa/Fix-PropsWindowIconNotShown
Jan 29, 2024
Merged
Fix: Fixed issue where the Properties window had the wrong icon #14470
yaira2
merged 6 commits into
files-community:main
from
0x5bfa:5bfa/Fix-PropsWindowIconNotShown
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
Fix: Fixed an issue where the props window icon was not shown
Fix: Fixed an issue where the property window had the default icon
Jan 16, 2024
yaira2
reviewed
Jan 16, 2024
…/0x5bfa/Files into 5bfa/Fix-PropsWindowIconNotShown
yaira2
reviewed
Jan 23, 2024
@yaira2 I think we better use MicaAlt and background mask to be consistent to the main window coloring. How about? |
MicaAlt is best used when there are more than two layers |
yaira2
changed the title
Fix: Fixed an issue where the property window had the default icon
Fix: Fixed an issue where the Properties window had the wrong icon
Jan 24, 2024
yaira2
approved these changes
Jan 24, 2024
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
Jan 26, 2024
yaira2
changed the title
Fix: Fixed an issue where the Properties window had the wrong icon
Fix: Fixed issue where the Properties window had the wrong icon
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As the title.
Task Checklist
N/A
Steps To Validate Changes
Known Issues
N/A
PR Checklist
Screenshots
Before:
Footnotes
If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request. ↩
If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead. ↩