Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the Properties window had the wrong icon #14470

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jan 16, 2024

Summary

As the title.

Task Checklist

N/A

Steps To Validate Changes

  1. Launch the app
  2. Open a properties window
  3. See window icon from the taskbar

Known Issues

N/A

PR Checklist

  • Development: N/A
  • Approval: Have discussed with and got approval from the team1
  • Tests: Tested accessibility on the local end
  • Deployment: Deployed the app on the local end
  • Localization: Modified en-US string resources2
  • Co-authors: N/A

Screenshots

Before:
image

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@yaira2 yaira2 changed the title Fix: Fixed an issue where the props window icon was not shown Fix: Fixed an issue where the property window had the default icon Jan 16, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Jan 24, 2024

@yaira2 I think we better use MicaAlt and background mask to be consistent to the main window coloring. How about?
image

@yaira2
Copy link
Member

yaira2 commented Jan 24, 2024

MicaAlt is best used when there are more than two layers

@yaira2 yaira2 changed the title Fix: Fixed an issue where the property window had the default icon Fix: Fixed an issue where the Properties window had the wrong icon Jan 24, 2024
@yaira2 yaira2 requested a review from d2dyno1 January 24, 2024 18:17
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 26, 2024
@yaira2 yaira2 merged commit c413174 into files-community:main Jan 29, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Fix-PropsWindowIconNotShown branch January 29, 2024 21:17
@yaira2 yaira2 changed the title Fix: Fixed an issue where the Properties window had the wrong icon Fix: Fixed issue where the Properties window had the wrong icon Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants