Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Introduce details layout columns generator phase 1 #14127

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 30, 2023

Summary

As of now, you have to add literally 250 lines only for one column when you are adding a new one (you can see git column introduction PR). We are introducing columns generator to mitigate that situation.

Task Checklist

  • Clean up
  • Introduce details layout columns generator

Steps To Validate Changes

  1. Launch the app
  2. Go to a folder
  3. Resize some columns
  4. Hide some columns
  5. Go to another folder
  6. See the columns you hid are shown in that folder
  7. Go to git folder
  8. See git columns appear

If nothing happen, you confirmed layout settings for each page are stored correctly in user_settings.db, hide/show operation is working properly, the app is able to fetch settings from the database and use them in an actual layout.

PR Checklist

Screenshots

Related codebase structure:
image

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@0x5bfa 0x5bfa changed the title Code Qualirt: Introduce details layout columns generator Code Qualirt: Introduce details layout columns generator 1 Nov 30, 2023
@yaira2 yaira2 changed the title Code Qualirt: Introduce details layout columns generator 1 Code Quality: Introduce details layout columns generator 1 Nov 30, 2023
@yaira2 yaira2 changed the title Code Quality: Introduce details layout columns generator 1 Code Quality: Introduce details layout columns generator phase 1 Dec 4, 2023
@yaira2
Copy link
Member

yaira2 commented Dec 4, 2023

Looks good behavior wise. I'd like to wait for an additional review from @gave92 or @hishitetsu before merging.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetHashCode() can be improved in the same way as LayoutPreferencesItem.

Copy link
Member Author

@0x5bfa 0x5bfa Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed already in the stage 2 PR. Thanks!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 5, 2023
@yaira2 yaira2 merged commit a422c87 into files-community:main Dec 5, 2023
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/Introduce-ColumnsGenerator branch December 5, 2023 04:07
@0x5bfa 0x5bfa restored the 5bfa/Introduce-ColumnsGenerator branch December 5, 2023 04:07
@0x5bfa 0x5bfa deleted the 5bfa/Introduce-ColumnsGenerator branch December 5, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants