Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for logging in/out of GitHub #14085

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Feature: Added support for logging in/out of GitHub #14085

merged 2 commits into from
Nov 26, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 26, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Switch git account and log out #13049...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Push commit from the stable version of Files to grant GitHub access
    2. Checkout this branch and navigate to settings, there should be a new settings page for "Git".
    3. Confirm the logout button removes the credentials and that the login button becomes visible
    4. Confirm the login button opens the authentication prompt

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as draft November 26, 2023 17:01
@yaira2 yaira2 marked this pull request as ready for review November 26, 2023 17:04
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 26, 2023
@yaira2 yaira2 merged commit 9e5b053 into main Nov 26, 2023
6 checks passed
@yaira2 yaira2 deleted the ya/GitPage branch November 26, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Switch git account and log out
1 participant