Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Open archives from the home page in the same tab #14069

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

pomydoro
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Open archives from the home page in the same tab #11517

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. In Home page scroll to an archive in Recent files.
    3. Open archive.

Screenshots (optional)
Archive in Recent files
files_recents_archive

Archive opened from Recent files
files_archive_opened

…s changed to assign StoregeItemType Folder to archives
@yaira2 yaira2 changed the title Feature: Archives from Recents in Home page open in the same tab Feature: Open archives from the home page in the same tab Nov 26, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for contributing to Files!

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 26, 2023
@yaira2 yaira2 merged commit 88c92a2 into files-community:main Nov 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Open archives from the home page in the same tab
2 participants