Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed COMException in UpdateDateDisplayTimer_Tick #14051

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Set the interval of _updateDateDisplayTimer to 0.1sec to increase the frequency of COMException.
    2. Open Files, display the date, and close the window.
    3. It crashes quite often without the fix, but it never crashes with the fix.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 24, 2023
@yaira2 yaira2 merged commit c57a1da into files-community:main Nov 24, 2023
5 checks passed
@hishitetsu hishitetsu deleted the FixCOMExceptionInTimer branch November 25, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
2 participants