Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed crash that could occur when installing a lot of font files #14024

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Fix: Fixed crash that could occur when installing a lot of font files #14024

merged 6 commits into from
Nov 28, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 22, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Don't install all selected fonts at once #13922...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as draft November 22, 2023 22:59
@yaira2 yaira2 added the help wanted Extra attention is needed label Nov 22, 2023
@yaira2 yaira2 changed the title Fix: Fixed crash that could occur when installing a bunch of font files Fix: Fixed crash that could occur when installing a lot of font files Nov 22, 2023
hishitetsu
hishitetsu reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way it should work fine.

src/Files.App/Utils/Shell/Win32API.cs Outdated Show resolved Hide resolved
src/Files.App/Actions/Content/Install/InstallFontAction.cs Outdated Show resolved Hide resolved
@yaira2 yaira2 marked this pull request as ready for review November 28, 2023 15:09
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed help wanted Extra attention is needed labels Nov 28, 2023
@yaira2
Copy link
Member Author

yaira2 commented Nov 28, 2023

@hishitetsu thank you for your help

@yaira2 yaira2 merged commit d51fecc into main Nov 28, 2023
6 checks passed
@yaira2 yaira2 deleted the ya/OptimizeFontInstall branch November 28, 2023 15:22
@yaira2 yaira2 mentioned this pull request Jan 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Don't install all selected fonts at once
2 participants
@yaira2 @hishitetsu