New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed NullReferenceException in MainPageViewModel.UpdateInstancePropertiesAsync #13900

Merged

yaira2 merged 1 commit into files-community:main from hishitetsu:FixNRE

Nov 16, 2023

Member

hishitetsu commented Nov 16, 2023

I don't know why an exception is thrown, but since this process only updates the window title, I ignore the exception when it is thrown.

Resolved / Related Issues

Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
https://appcenter.ms/orgs/FilesApp/apps/Files/crashes/errors/2912768630u/overview

Validation
How did you test these changes?

Did you build the app and test your changes?
Did you check for accessibility? You can use Accessibility Insights for this.
Did you remove any strings from the en-us resource file?
- Did you search the solution to see if the string is still being used?
Did you implement any design changes to an existing feature?
- Was this change approved?
Are there any other steps that were used to validate these changes?


          Update MainPageViewModel.cs

d7ed767

yaira2 approved these changes

View reviewed changes

Member

yaira2 left a comment

LGTM

yaira2 added the ready to merge label

yaira2 merged commit f7fa6fa into files-community:main

6 checks passed

hishitetsu deleted the FixNRE branch

November 17, 2023 02:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels