Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Fix async warnings #13832

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Code Quality: Fix async warnings #13832

merged 1 commit into from
Nov 13, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 12, 2023

Resolved / Related Issues
Fix async warnings

@yaira2 yaira2 requested a review from 0x5bfa November 12, 2023 19:04
0x5bfa
0x5bfa approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're some methods shall not be async but all of them here look good

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 13, 2023
@yaira2
Copy link
Member Author

yaira2 commented Nov 13, 2023

There're some methods shall not be async

How can this be determined and should we suppress the warning in those cases?

@yaira2 yaira2 merged commit 6d10970 into main Nov 13, 2023
6 checks passed
@yaira2 yaira2 deleted the ya/AddedMissingAwaits branch November 13, 2023 15:03
@0x5bfa
Copy link
Member

0x5bfa commented Nov 13, 2023

There're some methods shall not be async

How can this be determined and should we suppress the warning in those cases?

No warnings there. IntelliSense suggests to make it async but no warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @0x5bfa