Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed gap between the divider line and details layout browser header #13829

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Conversation

00000vish
Copy link
Contributor

Reopening since this should remove the gap and still provide functionality for context menu/selection rectangle in the space to the left of the file list to work properly.

fixed #13819

Screenshots

Screenshot 2023-11-11 213621

Screenshot 2023-11-11 213604

@yaira2 yaira2 changed the title Fix: Remove gap between the divider line and details layout browser header. Fix: Remove gap between the divider line and details layout browser header Nov 12, 2023
@yaira2 yaira2 changed the title Fix: Remove gap between the divider line and details layout browser header Fix: Removed gap between the divider line and details layout browser header Nov 12, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 12, 2023

This appears to have broken the alignment between the column headers and the columns
image

@00000vish
Copy link
Contributor Author

This appears to have broken the alignment between the column headers and the columns image

Yikes, sorry i miss this.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Nov 12, 2023
@yaira2 yaira2 merged commit 67b86b5 into files-community:main Nov 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annoying gap in details layout browser
2 participants