Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Disable copy path when no items are selected #13755

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 8, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Fixed crash with copy path action if no items are selected

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Use ctrl + shift + c shortcut when no items are selected and confirm app doesn't crash

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 assigned yaira2 and unassigned yaira2 Nov 8, 2023
@yaira2 yaira2 added needs - code review ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 8, 2023
@yaira2 yaira2 merged commit 5bc866e into main Nov 8, 2023
1 check passed
@yaira2 yaira2 deleted the ya/FixCopyPath branch November 8, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant