Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed "Drive Unplugged" error when compressing items in Column layout #13695

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix: Fixed "Drive Unplugged" error when compressing items in Column layout #13695

merged 2 commits into from
Nov 21, 2023

Conversation

William-Hiatt
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • [ X ] Did you build the app and test your changes?

@yaira2 yaira2 changed the title Fix: Created check to prevent "Drive Unplugged" error when compressing to 7z in column mode Fix: Fixed "Drive Unplugged" error when compressing items in Column layout Nov 6, 2023
@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 8, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 8, 2023

@gave92 this fixes the issues, but it removes the selection behavior from the other layouts. @William-Hiatt is already looking into an alternative approach.

@yaira2 yaira2 added needs - code review and removed ready to merge Pull requests that are approved and ready to merge labels Nov 8, 2023
@Lukiluc29
Copy link
Contributor

I just tested it, and it does indeed fix the error message issue. However, there are still some elements that remain selected.

@gave92
Copy link
Member

gave92 commented Nov 8, 2023 •
edited
Loading

@gave92 this fixes the issues, but it removes the selection behavior from the other layouts.

True, but only for archive files. Thought it was acceptable for v3 while we develop a more complete solution.

@yaira2 yaira2 force-pushed the main branch 3 times, most recently from cecddda to 7f8c927 Compare November 17, 2023 16:57
yaira2
yaira2 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 21, 2023
@yaira2 yaira2 merged commit 494153c into files-community:main Nov 21, 2023
6 checks passed
yaira2 added a commit to ferrariofilippo/Files that referenced this pull request Nov 23, 2023
@yaira2
Squashed commit of the following:
5043b3c 
commit 432b47c
Author: Yair <[email protected]>
Date:   Thu Nov 23 14:04:12 2023 -0500

    Update FUNDING.yml

commit f42f2ea
Author: Yair <[email protected]>
Date:   Thu Nov 23 10:01:39 2023 -0500

    Preview: 3.0.11

commit dfc7c2f
Author: Yair <[email protected]>
Date:   Thu Nov 23 10:00:16 2023 -0500

    Fix: Fixed check for admin (files-community#13971)

commit 79d31e3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Nov 23 09:52:34 2023 -0500

    Build(deps): Bump SQLitePCLRaw.bundle_green from 2.1.6 to 2.1.7 (files-community#14029)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit c0bb1b8
Author: Tony Barrera <[email protected]>
Date:   Wed Nov 22 18:53:53 2023 -0800

    Fix: Fixed an issue with drag and dropping items onto .py files (files-community#13986)

commit 4b58c2d
Author: Yair <[email protected]>
Date:   Wed Nov 22 17:12:09 2023 -0500

    Fix: Disable media preview for archive items (files-community#14021)

commit 00543d8
Author: Yair <[email protected]>
Date:   Wed Nov 22 16:34:25 2023 -0500

    Feature: Indicate "Always keep on device" status (files-community#14012)

commit 92c5231
Author: Yair <[email protected]>
Date:   Wed Nov 22 14:01:23 2023 -0500

    New Crowdin updates (files-community#14022)

commit b3c4d83
Author: 0x5bfa <[email protected]>
Date:   Thu Nov 23 00:18:41 2023 +0900

    Code Quality: Renamed layout page classes to improve readability (files-community#13958)

commit 1e1bbe7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 22 09:50:51 2023 -0500

    Build(deps): Bump Microsoft.CodeAnalysis.CSharp from 4.5.0 to 4.8.0 (files-community#14017)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 5adae99
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Nov 22 09:50:36 2023 -0500

    Build(deps): Bump Microsoft.Graphics.Win2D from 1.1.0 to 1.1.1 (files-community#14016)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 8e974c7
Author: Yair <[email protected]>
Date:   Tue Nov 21 21:39:12 2023 -0500

    Feature: Display error when failing to calculate the hash of open files (files-community#14014)

commit bf7b5da
Author: Yair <[email protected]>
Date:   Tue Nov 21 21:18:46 2023 -0500

    Fix: Fixed NullReferenceException in GetCompressDestination (files-community#14007)

commit 79855ba
Author: Yair <[email protected]>
Date:   Tue Nov 21 17:36:37 2023 -0500

    Fix: Fixed xamlRoot in the ConsentDialog (files-community#14013)

commit 494153c
Author: William-Hiatt <[email protected]>
Date:   Tue Nov 21 13:17:49 2023 -0800

    Fix: Fixed "Drive Unplugged" error when compressing items in Column layout (files-community#13695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@gave92 gave92 gave92 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: "Drive unplugged" error in Column Layout when compressing items
4 participants
@William-Hiatt @yaira2 @Lukiluc29 @gave92