Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed NullReferenceException with DefaultDestinationFolderPath #13662

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 5, 2023

Resolved / Related Issues

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to consider the case where SlimContentPage is null.

@yaira2
Copy link
Member Author

yaira2 commented Nov 6, 2023

In DecompressArchiveDialogViewModel?

@hishitetsu
Copy link
Member

Here, for example.

foreach (var selectedItem in associatedInstance.SlimContentPage.SelectedItems)

@yaira2
Copy link
Member Author

yaira2 commented Nov 6, 2023

Do you think that's enough, or should I keep my other changes as well?

@hishitetsu
Copy link
Member

hishitetsu commented Nov 6, 2023

I don't think the archive will ever be null, but it could be left for safety. However, continue would be more appropriate than return.

@yaira2 yaira2 requested a review from hishitetsu November 6, 2023 17:16
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 7, 2023
@yaira2 yaira2 merged commit 93b1566 into main Nov 7, 2023
1 check was pending
@yaira2 yaira2 deleted the ya/DefaultDestinationFolderPath- branch November 7, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants