-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub: Added build CI #13620
GitHub: Added build CI #13620
Conversation
It'd be good to cache NuGet packages by setting
Note: I haven't tested this at all |
@heftymouse You mean this save us time about 3 minis in running Restore NuGet?
I'd rather wait to add this feature here now because I'm not sure I can run restoring when one of the cached dependencies updated, which is very important. |
That's what the lockfile and the I'm realising now that a better approach would be to just restore every time and cache the result, so if any of the dependencies change it just has to restore the changes |
Is it better behavior that CI restores from nuget.org (takes 3 min) and cache result always on the main branch (on: push) and CI restores only from cached pool to make the CI on the PR (on: pull_request) as fast as and as reliable as possible? |
Sure, that works |
For the time being, I'd rather keep as is. @yaira2 Ready for review. |
.NET test is failing now. |
Ready for merging |
Summary
We are finally going to make build & test CI on the GitHub Actions to gain better integrity. This enables us to configure and manage the CI easily, and have better access to the package artifacts.
We had some difficulties below (wrote down to view quickly what we've overcome)
Task Checklist
Added creator of a comment on PRKnown Issues
N/A
PR Checklist
Steps To Validate Changes
Screenshots
N/A
Footnotes
If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request. ↩
If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead. ↩