Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash when dragging files from Gmail #13528

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 17, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Save from Gmail #13473

NB: this change fixes the crash but the attachment is created as an internet shortcut (.url) file instead of an actual file like explorer does. Regardless the added try-catch is needed.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Drag attachment from web GMail to Files

@yaira2 yaira2 changed the title Fix: Fixed crash when dragging files from GMail Fix: Fixed crash when dragging files from Gmail Oct 17, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 17, 2023
@yaira2 yaira2 merged commit 987650a into files-community:main Oct 17, 2023
1 check passed
@gave92 gave92 deleted the issue_13473 branch October 18, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save from Gmail
2 participants