Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where new files were sometimes created in the wrong directory #13523

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Error when creating new txt file #13090

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu changed the title Fix: Fixed an issue where files were sometimes created in the wrong directory Fix: Fixed an issue where new files were sometimes created in the wrong directory Oct 17, 2023
@yaira2
Copy link
Member

yaira2 commented Oct 17, 2023

I haven't been able to repro this issue on my end so I'll take your word that this fixes it.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 17, 2023
@yaira2 yaira2 merged commit fa99e89 into files-community:main Oct 17, 2023
1 check passed
@hishitetsu hishitetsu deleted the FixNewFileInWrongDirectory branch October 18, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error when creating new txt file
2 participants