Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Repurpose Ctrl+Shift+N shortcut to create new folder #13505

Merged

Conversation

kworede582
Copy link
Contributor

@kworede582 kworede582 commented Oct 11, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Feature: Auto create folder when using ctrl + shift + n shortcut #10396

Validation
How did you test these changes?

  • [ X] Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.
Made the changes to enable auto create folder when using ctrl + shift + n shortcut: Feature: #10396
Before making the changes:
image

After making the changes:
image

@yaira2
Copy link
Member

yaira2 commented Oct 11, 2023

@kworede582 thank you for contributing and congrats on your first PR to Files! We still haven't approved the feature request in #10396 but I'll take a look and let you know what we decide.

@kworede582
Copy link
Contributor Author

Requirements fulfilled:

  • 'Ctrl + Shift + n' shortcut will no longer display the new item dialog box with multiple/different options
  • Shortcut will now auto prompt user to enter the folder name

@yaira2
Copy link
Member

yaira2 commented Oct 11, 2023

That's the current proposal but it's still in the planning stage (you can check the status in the right pane). In the meantime, let's leave this open and I'll let you know once we finish reviewing the request.

@yaira2 yaira2 changed the title Create new folder wiht Ctrl+Shift+N shortcut Feature: Repurpose Ctrl+Shift+N shortcut to create new folder Oct 12, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 12, 2023
@yaira2 yaira2 merged commit 94df174 into files-community:main Oct 12, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants