Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for opening Git root in VS Code #13498

Merged
merged 13 commits into from
Oct 10, 2023
Merged

Feature: Added support for opening Git root in VS Code #13498

merged 13 commits into from
Oct 10, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Oct 10, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open sub folder in a Git epo
    2. Click the open button on the status bar
    3. Confirm that choosing "open repo" opened the root of the Git repo
    4. Confirm that choosing "open folder" opens the current directory

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 marked this pull request as draft October 10, 2023 17:27
@yaira2 yaira2 changed the title Feature: Add support for opening Git root in VS Code Feature: Added support for opening Git root in VS Code Oct 10, 2023
@yaira2 yaira2 marked this pull request as ready for review October 10, 2023 20:31
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 10, 2023
@yaira2 yaira2 merged commit c79d0cc into main Oct 10, 2023
1 of 2 checks passed
@yaira2 yaira2 deleted the ya/vscode branch October 10, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Open in VS/VSCode button should open the root of the repo
2 participants