New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Support for browsing the contents of .lzh files #13333

Merged

yaira2 merged 1 commit into files-community:main from hishitetsu:LzhIsBrowsable

Sep 5, 2023

Member

hishitetsu commented Sep 5, 2023

.lzh is pure archive file, so it should be browsable.

Resolved / Related Issues

Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #issue...

Validation
How did you test these changes?

Did you build the app and test your changes?
Did you check for accessibility? You can use Accessibility Insights for this.
Did you remove any strings from the en-us resource file?
- Did you search the solution to see if the string is still being used?
Did you implement any design changes to an existing feature?
- Was this change approved?
Are there any other steps that were used to validate these changes?


          Update FileExtensionHelpers.cs

e3cdc69

yaira2 approved these changes

View reviewed changes

Member

yaira2 left a comment

LGTM

yaira2 added the ready to merge label

yaira2 merged commit 52892cb into files-community:main

1 check passed

hishitetsu deleted the LzhIsBrowsable branch

September 5, 2023 16:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels