Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where tab headers sometimes didn't match actual content #13326

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Sep 4, 2023

This PR also fixes the issue of tab tooltips not updating in case of dual pane.

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open the home page.
    2. Click a sidebar item (ex: Documents).
    3. Quickly click Home on the sidebar.
    4. The tab header is no longer displayed with the contents of 2.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 4, 2023
@yaira2 yaira2 merged commit 4df04e9 into files-community:main Sep 4, 2023
1 check passed
@hishitetsu hishitetsu deleted the TabItemSync branch September 5, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tabs, address bar, and folder content get out of sync when adding multiple tabs at once
2 participants