Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Fixed A11y issues in settings dialog #13314

Merged
merged 2 commits into from
Sep 3, 2023
Merged

Code Quality: Fixed A11y issues in settings dialog #13314

merged 2 commits into from
Sep 3, 2023

Conversation

marcelwgn
Copy link
Contributor

Resolved / Related Issues

  • Fixes pipeline failing due to a11y issues with the settings dialog

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix A11y issues in settings dialog Code Quality: Fix A11y issues in settings dialog Sep 3, 2023
@yaira2 yaira2 changed the title Code Quality: Fix A11y issues in settings dialog Code Quality: Fixed A11y issues in settings dialog Sep 3, 2023
yaira2
yaira2 approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaira2 yaira2 merged commit b0708db into files-community:main Sep 3, 2023
2 checks passed
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelwgn @yaira2 @0x5bfa