Code Quality: Refactor Status Center code

[0x5bfa]

Feature: Display transfer speed in status center

Motivation & Context

• Removed IStatusCenterAction interface used to access viewmodel because we now have Dependency injection.
• Removed PostedStatusBanner class and merged it to StatusBanner class which was renamed to StatusCenterItem
• Renamed some classes to use same words
• Updated UI

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  • Open Files
  • Copy/move/delete files
  • Open StatusCenter
  • You see what has been changed

PR TO-DO

• Remove InfoBar
• Add color visual states

Concepts

Screenshots

[mdtauk]

I know it matches the design I originally set out to do, but I would value some input to improve visibility of the Speed line, and see what options we have.

Other examples...

Something like this may be a bit cleaner

[yaira2]

@0x5bfa we haven't finalized any plans around this flyout.

[yaira2]

I'd like to get a speed graph in there sooner than later, but we need to spec this out.

[0x5bfa]

I can wait. how long will it take?

I thought the spec was already formulated when you mentioned this concepts and I raised my hand.

[mdtauk]

I can wait. how long will it take?

I thought the spec was already formulated when you mentioned this concepts and I raised my hand.

The concepts were done like a year or two ago. There was going to be a task UI "Status centre" and it was at a different time.

I was not asked to look into it any further since, so I guess we can work on this aspect and maybe implement it later, when other bits are figured out.

• Do we want this flyout UI to be always accessible?
• Do we automatically remove completed tasks?
• Do we want notifications when apps are in the background? (Adaptive Cards?)
• Do we want the icon for this UI to reflect progress or number of tasks in operation?
• How do we handle a polished transition between progress and graph?

[mdtauk]

This is what we are working towards right now

Hover to show the remove button on completed and failed actions - @yaira2 suggested for touch that this is handled with the SwipeControl

[mdtauk]

Here is a rough idea of how we could transition from a Progress control to a Progress Chart - how possible is something like this @0x5bfa

Replaced the video with one where the Progress Bar style before expansion, matches the system style.

status.card.expanding.chart.2.mp4

[0x5bfa]

Ready for review for me.

[yaira2]

Are there any other steps that were used to validate these changes?

Can you share some testing steps?

[0x5bfa]

omg i'm sorry i will add soon (i'm in bed so it will be tomorrow)

[yaira2]

It looks good code wise.

[0x5bfa]

Done

[yaira2]

Open StatusCenter

Does this work for you? The app crashes when I try opening the status center.

[0x5bfa]

Last time I tested successfully is 1a120fe

[QuaintMako]

Great work! I don't have much to add aside of very small formatting ideas. Thanks for handling this big feature!

[QuaintMako]

LGTM code-wise, I am not able to test in-app.

[yaira2]

I ran some tests and it works as expected, nice work!

[yaira2]

It looks like this was being used in a visual state, I'll open a PR to fix.