-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added an option to keep Files running in the background for quicker startup time #13236
Conversation
All known issues were resolved. Now ready for review. |
It is true that the behavior is different from when the process is terminated without caching, but I think it doesn't matter. |
Yes, but it's a bit bothersome because when I close Files, I don't necessarily want to see the status center when I reopen Files, especially when I haven't taken any action upon its reopening. |
@Lukiluc29 this is the expected behavior because you aren't actually closing Files, you're leaving it open in the background. |
Users tend to close applications after using them, and they might find it disruptive to encounter a status center that they didn't initiate themselves. By removing the status center in this scenario, we can enhance the user's sense of control and provide a smoother and more intuitive interaction with the application. |
I rather think that notifications should remain even after restarting the app unless the user explicitly clears them. In any case, this is something we can discuss as a separate issue. |
Where can we discuss this? |
You can open a new issue once this PR is merged. |
Co-authored-by: Yair <[email protected]>
…into CacheMainWindow
When the app is in the background, could Files use the system notifications to alert on the completion of on-going tasks? |
It stops the thread, so that may be difficult as it is now. |
For what it's worth, file operations already continue in the background even if the app is fully terminated. The missing part is displaying a notification, and that's being tracked in the issue @hishitetsu linked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me in terms of the codebase quality!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice improvement, it's a lot more enjoyable to use Files when you don't have to wait for it to load. LGTM!
Resolved / Related Issues
Closes Feature: Cache windows for quicker startup #12614
Validation
How did you test these changes?
Known Issues
When only one tab is opened, the tab is not visually selected.Closing the main window while a property window is still open freezes the property window until the next time the main window is opened.The content flashes while it loads.