Code Quality: Refactored tab control

[0x5bfa]

Code Quality: Clean up multitasking control

I'm actually surprised how the code was complicated. This would be a milestone for implementation of the templated custom tabview for the future.

Motivation & Context

• Improved readability
• Improved maintainability

PR Checklist

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
  Related Code Quality: Continued work to clean up entire project #12340
• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  • Open the app
  • Add a new tab, see contents changed properly
  • Close a tab, see contents changed properly
  • Right click a tab, see menu is shown properly
  • If you dont see nothing changed, changes were validated.

Screenshots

[ferrariofilippo]

Overall, the code looks good, except in a few cases.
You might consider removing using Files.App.UserControls.TabView from most of the files.
I'm not a big fan of the new class names, they are in conflict with existing ones. They might confuse other contributors

[0x5bfa]

I'm not a big fan of the new class names, they are in conflict with existing ones.

Does anyone have an idea?

[0x5bfa]

CustomTabView will do.

[ferrariofilippo]

CustomTabView will do.

This one sounds good

[0x5bfa]

@yaira2 do you have plans to create custom template tabview? it is supposed to be easier than sidebar tbh.

[yaira2]

@0x5bfa you mean a custom control like we did with the sidebar? It's something I'd like to do at some point but there is a lot of logic (particularly around resizing the tabs) so it's quite a large task.

[0x5bfa]

Ready for review. @yaira2

[0x5bfa]

@yaira2 I can rename CustomTabView with something else if you dont like it such as MultitaskingTabView.

[yaira2]

@0x5bfa what's in scope for this PR?

[0x5bfa]

• Refactor/simplify MultitaskingControl code
• Rename MultitaskingControl with CustomTabView.

[0x5bfa]

Unwrapped the content frame from usercontrol, so slight performance improvement will be expected.

[yaira2]

I'm not a big fan of the new class names, they are in conflict with existing ones.

Does anyone have an idea?

How about HorizontalTabView?

[0x5bfa]

If we are certainly going to implement vertical one. But if not, I don't like it.

[yaira2]

Vertical tabs aren't in the plans

[0x5bfa]

Then adding Horizontal is not appropriate I believe.

[yaira2]

What about TabBar?

[0x5bfa]

Sounds great. Would you like me to change to be it?

[yaira2]

LGTM

[QuaintMako]

LGTM.

[yaira2]

@0x5bfa can you look into the build error?

[yaira2]

@0x5bfa can you also share some steps to test these changes? Ideally this would include all the different functionality around the tab bar.

[0x5bfa]

@0x5bfa can you also share some steps to test these changes? Ideally this would include all the different functionality around the tab bar.

No changes were made of functionalities. But cleaned up codebase to make them have clear purpose of existence. Just opening the app would check if this changes were appropriately made.

[0x5bfa]

Please take another look.

[0x5bfa]

Done

[yaira2]

@0x5bfa looks good, thank you for the PR.