Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed cloud icon for OneDrive work accounts #13148

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 7, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Use correct icon for work OneDrive accounts #8313...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Confirm the sidebar displays the OneDrive icon for OneDrive work accounts

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 requested a review from gave92 August 7, 2023 16:05
@yaira2 yaira2 changed the title Fix: Fixed cloud icon for OneDrive Fix: Fixed cloud icon for OneDrive work accounts Aug 7, 2023
@yaira2
Copy link
Member Author

yaira2 commented Aug 21, 2023

@Lukiluc29 fyi

@Lukiluc29
Copy link
Contributor

Thank you, I didn't think it would fix the issue, but in the end it did.

@Lukiluc29
Copy link
Contributor

The icon in the sidebar updated successfully, but not in the preview pane.
Capture d'écran 2023-08-21 182911

@yaira2
Copy link
Member Author

yaira2 commented Aug 21, 2023

I applied custom logic in the sidebar so that it doesn't look out of place next to the regular OneDrive item, but at the end of the day, the folder icon is the icon provided by Windows (I imagine File Explorer does the same).

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 21, 2023
@yaira2 yaira2 merged commit ca619d1 into main Aug 21, 2023
@yaira2 yaira2 deleted the ya/FixOneDriveIcon branch August 21, 2023 16:41
@Lukiluc29
Copy link
Contributor

This doesn't solve the issue because my OneDrive, which previously didn't have an icon in the sidebar, now has one, but still not in the preview pane. It displays as a regular folder there, whereas the other one, where the icon was correctly displayed in the sidebar, also appears correctly in the preview pane.
Capture d'écran 2023-08-21 182911
Capture d'écran 2023-08-21 184450

@yaira2
Copy link
Member Author

yaira2 commented Aug 21, 2023

As mentioned above, the icon in the preview pane is the actual icon provided by File Explorer. We made an exception to override the real icon in the left-hand sidebar, but this is indeed the expected behavior.

@Lukiluc29
Copy link
Contributor

Where can this problem come from? In my file explorer it shows me the OneDrive icon.
Capture d'écran 2023-08-21 190115
Capture d'écran 2023-08-21 190106

@yaira2
Copy link
Member Author

yaira2 commented Aug 21, 2023

It's possible they have custom behavior for the preview pane as well, as of now we don't plan to do this but it's not impossible that we'll do this at some point.

@Lukiluc29
Copy link
Contributor

Finally, by completely uninstalling OneDrive, everything went back to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Use correct icon for work OneDrive accounts
2 participants