Feature: Removed margin when using the Compact Spacing option

[yaira2]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Feature: Reduce margin in the compact spacing option #12012...

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Enable compact spacing
  2. Confirm there is no space between items in the details layout

Screenshots (optional)

[mdtauk]

This looks poorly designed

[ferrariofilippo]

This looks poorly designed

Actually I love it
Anyway, @yaira2 I get this exception when I try to navigate to Home. The issue is that I fall in a crash loop and I can't start the app again

[mdtauk]

I understand people wanting closer spacing, but it still needs some tweaks to make it look polished

[yaira2]

@ferrariofilippo can you check if the latest commit fixed the exception?

[ferrariofilippo]

Everything works fine now! I have another request: can you add VerticalAlignement = Center to RecentFiles, SecurityPage and AdvancedSecurityPage?

[yaira2]

SecurityPage and AdvancedSecurityPage?

Do these need it? It should be using the default template now (compact styles don't apply to these pages anymore).

RecentFiles

It's already applied to recent files, can you check again?

[ferrariofilippo]

SecurityPage and AdvancedSecurityPage?

Do these need it? It should be using the default template now (compact styles don't apply to these pages anymore).

I don't know why but I could still see the compact layout. Now it looks good!

RecentFiles

It's already applied to recent files, can you check again?

It's working. I guess .txt icons have some spacing above, since they are the only ones who doesn't seem centered

[yaira2]

Can you share a screenshot?

[ferrariofilippo]

LGTM!

[ferrariofilippo]

Can you share a screenshot?

The txt file has 1/2 pixels of space above, instead the js file fills all the space

[yaira2]

This will be fixed when we switch to using smaller icons with compact spacing.