Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed compact spacing alignment in the Column Layout #13144

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 6, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Enable compact spacing
    2. Switch to the columns layout
    3. Confirm items have the correct vertical alignment

Screenshots (optional)
Add screenshots here.

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me!

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 7, 2023
@yaira2 yaira2 merged commit 3328f08 into main Aug 7, 2023
@yaira2 yaira2 deleted the ya/FixedCompactColumns branch August 7, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Items aren't vertically centers in column layout (with compact spacing)
2 participants