Feature: Updated the design of the Tags section in the Details Pane

[yaira2]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Related to Feature: Add edit tags button to the preview pane #12946

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open details pane
  2. Edit the tags using the menu flyout

Screenshots (optional)

[yaira2]

@ferrariofilippo fyi

[Lukiluc29]

I'm sorry for intruding on your design update, but is it possible to fix the issue where we have to go back to the file/folder to see the tags?

[yaira2]

I'm sorry for intruding on your design update, but is it possible to fix the issue where we have to go back to the file/folder to see the tags?

Can you open an issue for this?

[ferrariofilippo]

Can you open an issue for this?

Maybe it's something with this PR because it's working in Preview

[yaira2]

@ferrariofilippo what are the steps to repro the issue?

[ferrariofilippo]

You're not updating the flyout when the selected item changes
(Screenshots are from an older commit)

@yaira2 line 53 shold fix all the issues

[ferrariofilippo]

@ferrariofilippo what are the steps to repro the issue?

Open the preview pane select a folder, change the selected folder and try to edit tags

[Lukiluc29]

I even found another issue! When I add a tag using the new button, the selected label is not assigned to the folder itself, but instead to the "Documents" folder in my case. However, when I click on another folder, like "Images" for example, the tag I selected for the previous folder is still selected.

[Lukiluc29]

To summarize, all the tags that I apply, regardless of their location or the folder they are in, are associated with the "Documents" folder.

[ferrariofilippo]

To summarize, all the tags that I apply, regardless of their location or the folder they are in, are associated with the "Documents" folder.

The screenshot I posted above fixes all the issues

[Lukiluc29]

The screenshot I posted above fixes all the issues

All right

[Lukiluc29]

I understand that I may be bothering you a bit, but I was wondering if it would be possible to decrease the space between each tag line. This would help save some space, especially when there are numerous tags (as shown in the example below).

[ferrariofilippo]

LGTM and works for me!