Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where the file area would sometimes lose focus when opening a folder #13130

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected.

@yaira2 yaira2 changed the title Fix: Fixed issue where the list sometimes wouldn't focus correctly when a folder is opened Fix: Fixed an issue where the file area would sometimes lose focus when opening a directory Aug 6, 2023
@yaira2 yaira2 changed the title Fix: Fixed an issue where the file area would sometimes lose focus when opening a directory Fix: Fixed an issue where the file area would sometimes lose focus when opening a folder Aug 6, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 6, 2023
@yaira2 yaira2 merged commit 2dfdd3f into files-community:main Aug 6, 2023
@hishitetsu hishitetsu deleted the FocusList branch August 6, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Entering a directory with keyboard Enter causes focus loss of the directory pane.
3 participants