-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed an issue were installing a font would freeze the app #13125
Merged
yaira2
merged 10 commits into
files-community:main
from
marcofranzen99:12474_RunPowershellCommand_Freezes
Aug 6, 2023
Merged
Fix: Fixed an issue were installing a font would freeze the app #13125
yaira2
merged 10 commits into
files-community:main
from
marcofranzen99:12474_RunPowershellCommand_Freezes
Aug 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for including detailed steps on what you did to test these changes 🎉 |
yaira2
reviewed
Aug 3, 2023
d2dyno1
reviewed
Aug 3, 2023
yaira2
changed the title
Fix: Fixed some issues where files would freeze
Fix: Fixed an issue were installing a font would freeze the app
Aug 6, 2023
d2dyno1
approved these changes
Aug 6, 2023
@mafra99 thank you |
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes Bug: Installing a font causes Files to freeze #12474
Validation
How did you test these changes?
Changes
Created RunPowershellCommandAsync method which uses async/await to wait for the powershell command to complete.
I replaced the non async method wit the async method in all places where i knew how to test it. In 5 places the non async method is still used.
Steps used to test the changed - noticeable freezes
Steps used to test the changes - no freeze but code has changed