Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue were installing a font would freeze the app #13125

Merged

Conversation

marcofranzen99
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Installing a font causes Files to freeze #12474

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Changes
Created RunPowershellCommandAsync method which uses async/await to wait for the powershell command to complete.
I replaced the non async method wit the async method in all places where i knew how to test it. In 5 places the non async method is still used.

Steps used to test the changed - noticeable freezes

  • Install Font
    • Select multiple *.ttf files
    • Install them with the Install button from the command bar or menu flyout
  • Run With Powershell
    • Select a powershell script
    • Execute it with the button from the command bar
  • Set Files as the default file manager
    • (There was a noticeable freeze on the toggle button, animation is now smooth)
    • Open Settings > Advanced
    • Toggle ‘Set Files as default file manager’
  • Open Format Drive
    • (Files was not responding while the format dialog was open, now you can continue to use Files while the dialog is open)
    • Format drive from the sidebar
    • Navigate to empty drive > Format drive
    • Format drive from drives widget
  • Mount VHD Disk
    • Select a *.vhd file
    • Mount disk via menu flyout

Steps used to test the changes - no freeze but code has changed

  • Open in VS action
    • Navigate to a git repository with a .sln file
    • Click Open in VS
  • Open in VSCode action
    • Navigate to a git repository
    • Click Open in VSCode

@yaira2
Copy link
Member

yaira2 commented Aug 3, 2023

Thank you for including detailed steps on what you did to test these changes 🎉

@yaira2 yaira2 requested a review from d2dyno1 August 6, 2023 18:20
@yaira2 yaira2 changed the title Fix: Fixed some issues where files would freeze Fix: Fixed an issue were installing a font would freeze the app Aug 6, 2023
@yaira2 yaira2 merged commit 7679e78 into files-community:main Aug 6, 2023
@yaira2
Copy link
Member

yaira2 commented Aug 6, 2023

@mafra99 thank you

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Installing a font causes Files to freeze
4 participants