-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Increased the text box height when renaming items in the tiles layout #13114
Merged
yaira2
merged 14 commits into
files-community:main
from
KlenAr313:larger_rename_textbox
Sep 21, 2023
Merged
Feature: Increased the text box height when renaming items in the tiles layout #13114
yaira2
merged 14 commits into
files-community:main
from
KlenAr313:larger_rename_textbox
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Aug 1, 2023
yaira2
reviewed
Aug 1, 2023
yaira2
reviewed
Aug 1, 2023
KlenAr313
force-pushed
the
larger_rename_textbox
branch
from
August 2, 2023 13:03
06a0e4e
to
959b276
Compare
…Files into larger_rename_textbox
yaira2
reviewed
Aug 6, 2023
yaira2
reviewed
Aug 13, 2023
yaira2
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@KlenAr313 sorry for the delay on reviewing this PR, it's looking good. |
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
changes requested
Changes are needed for this pull request
labels
Sep 21, 2023
yaira2
changed the title
Feature: Make the rename text box larger
Feature: Increased the text box height when renaming items in the tiles layout
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes Feature: Make the rename text box larger #12321
Validation
How did you test these changes?
I did check accessibility, and I didn't find any errors in my code, but some were on the page unrelated to this task.
Screenshots (optional)
Still the original when nothing happens:
When it is a short name, the textbox automatically adjusts its size:
When the available space is full:
When the name is longer, it can be scrolled vertically:
If there's a long continuous word, it would break in the middle, which doesn't allow horizontal scrolling.
Pictures from grid view: