Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Increased the text box height when renaming items in the tiles layout #13114

Merged
merged 14 commits into from
Sep 21, 2023

Conversation

KlenAr313
Copy link
Contributor

@KlenAr313 KlenAr313 commented Aug 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Make the rename text box larger #12321

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

I did check accessibility, and I didn't find any errors in my code, but some were on the page unrelated to this task.

Screenshots (optional)
Still the original when nothing happens:
Raw

When it is a short name, the textbox automatically adjusts its size:
Small

When the available space is full:
Ful

When the name is longer, it can be scrolled vertically:
Scroll

If there's a long continuous word, it would break in the middle, which doesn't allow horizontal scrolling.

Pictures from grid view:
GLong
Képernyőkép 2023-08-02 142748
Képernyőkép 2023-08-02 142855

@KlenAr313
Copy link
Contributor Author

I did check accessibility, and I didn't find any errors in my code, but some were on the page unrelated to this task.

Do you know what the errors were? I'd like to keep track so we can fix them.

I found these in Tiles mode. Unfortunately, it doesn't say where they are.
Errors
I think only the first one is relevant because the others are duplicates.

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Aug 1, 2023
@KlenAr313 KlenAr313 force-pushed the larger_rename_textbox branch from 06a0e4e to 959b276 Compare August 2, 2023 13:03
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Sep 21, 2023

@KlenAr313 sorry for the delay on reviewing this PR, it's looking good.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Sep 21, 2023
@yaira2 yaira2 changed the title Feature: Make the rename text box larger Feature: Increased the text box height when renaming items in the tiles layout Sep 21, 2023
@yaira2 yaira2 merged commit a651475 into files-community:main Sep 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Make the rename text box larger
2 participants