Code Quality: Use TaskCompletionSource for splash screen loading

src/Files.App/App.xaml.cs

@@ -47,7 +47,7 @@ public partial class App : Application
 		private static bool ShowErrorNotification = false;
 		public static string OutputPath { get; set; }
 		public static CommandBarFlyout? LastOpenedFlyout { get; set; }
-		public static bool IsSplashScreenLoading { get; set; }
+		public static TaskCompletionSource IsSplashScreenLoading { get; set; }
 
 		public static StorageHistoryWrapper HistoryWrapper { get; } = new();
 		public static AppModel AppModel { get; private set; }
@@ -214,7 +214,7 @@ async Task ActivateAsync()
 				// Wait for the Window to initialize
 				await Task.Delay(10);
 
-				IsSplashScreenLoading = true;
+				IsSplashScreenLoading = new TaskCompletionSource();
 				MainWindow.Instance.ShowSplashScreen();
 
 				// Get AppActivationArguments
@@ -235,13 +235,7 @@ async Task ActivateAsync()
 				Logger.LogInformation($"App launched. Launch args type: {appActivationArguments.Data.GetType().Name}");
 
 				// Wait for the UI to update
-				for (var i = 0; i < 50; i++)
-				{
-					if (IsSplashScreenLoading)
-						await Task.Delay(10);
-					else
-						break;
-				}
+				await IsSplashScreenLoading.Task.WithTimeoutAsync(TimeSpan.FromMilliseconds(500));
 
 				_ = InitializeAppComponentsAsync().ContinueWith(t => Logger.LogWarning(t.Exception, "Error during InitializeAppComponentsAsync()"), TaskContinuationOptions.OnlyOnFaulted);
 

src/Files.App/Views/SplashScreenPage.xaml.cs

@@ -18,12 +18,12 @@ public SplashScreenPage()
 
 		private void Image_ImageOpened(object sender, RoutedEventArgs e)
 		{
-			App.IsSplashScreenLoading = false;
+			App.IsSplashScreenLoading.TrySetResult();
 		}
 
 		private void Image_ImageFailed(object sender, RoutedEventArgs e)
 		{
-			App.IsSplashScreenLoading = false;
+			App.IsSplashScreenLoading.TrySetResult();
 		}
 	}
 }