Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where the app sometimes got stuck on splash screen #13013

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix: Fixed issue where the app sometimes got stuck on splash screen #13013

merged 1 commit into from
Jul 21, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Jul 21, 2023 •
edited
Loading

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu changed the title Fix: Fixed issue where the app gets stuck on splash screen when launching from CLI by specifying the path Fix: Fixed issue where the app got stuck when launching from CLI by specifying the path Jul 21, 2023
@hishitetsu hishitetsu changed the title Fix: Fixed issue where the app got stuck when launching from CLI by specifying the path Fix: Fixed issue where the app sometimes got stuck on splash screen Jul 21, 2023
@hishitetsu hishitetsu mentioned this pull request Jul 21, 2023
Closed
yaira2
yaira2 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 21, 2023
@yaira2 yaira2 merged commit f6a7445 into files-community:main Jul 21, 2023
@hishitetsu hishitetsu deleted the LaunchFromCLI branch July 21, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
2 participants
@hishitetsu @yaira2