Feature: Added a Command Palette

[hishitetsu]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Feature: Add command palette #2780

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Type ">" in the address bar or press Ctrl+Shift+P to open the command palette
  2. You can search commands by both description (translated) and command code.
  3. Select a suggestion or type a command code to invoke the command.

Screenshots

[0x5bfa]

How about this?

• When user entered >, display custom glyph with background accent color filled.
  (made by @mdtauk)
  

[hishitetsu]

• When user entered >, display custom glyph with background accent color filled.

Not implemented yet. In fact, I'm not sure how to implement it.

[mdtauk]

• When user entered >, display custom glyph with background accent color filled.

Not implemented yet. In fact, I'm not sure how to implement it.

I would suggest perhaps looking at the Tokenizing TextBox from the Community Toolkit

Or just modifying the template to shift the Text part 32px in from the left, and overlay an icon?

[0x5bfa]

Or just modifying the template to shift the Text part 32px in from the left, and overlay an icon?

I would rather do this.

• If you press backspace, that indicator would disappear.
• If you press > it would appear.

[0x5bfa]

tiny things

[0x5bfa]

LGTM in terms of codebase quality

[yaira2]

@hishitetsu I tested the feature and it's working really well, the only feedback I have is that we should remove the command name, and that we should hide commands that aren't enabled.

[hishitetsu]

we should remove the command name

The command name is important for non-English users because they will want to search for commands both in their native language and in English. Would it be better to show the English description rather than the command name, which is what Visual Studio Code does?

we should hide commands that aren't enabled

I don't think so because users may want to know what commands exist. But you want to hide them, I will do so.

[yaira2]

@hishitetsu I meant only to hide the name, we can still include the name in the search query.

I don't think so because users may want to know what commands exist. But you want to hide them, I will do so.

I personally found them confusing, but we can always reevaluate down the line and besides, I think this concern will be resolved when we add a settings page for remapping shortcuts.

[hishitetsu]

@yaira2 updated. How about this?

[yaira2]

LGTM

[mdtauk]

Is there any value in only using the Semibold font for the characters you have typed into the Command Box?

This would match the Microsoft Store

[hishitetsu]

Is there any value in only using the Semibold font for the characters you have typed into the Command Box?

I tried to find it, but could not.
https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.xaml.controls.autosuggestbox?view=windows-app-sdk-1.3

[0x5bfa]

that must be implemented by themselves.

[mdtauk]

Its not an automatic feature, we would have to parse the string, and provide probably Runs within TextBlocks with the characters styled.

[hishitetsu]

Its not an automatic feature, we would have to parse the string, and provide probably Runs within TextBlocks with the characters styled.

Implemented in #13095

[mdtauk]

Its not an automatic feature, we would have to parse the string, and provide probably Runs within TextBlocks with the characters styled.

Implemented in #13095

Wow that was fast work, thank you. I think it does make a difference in polish and adds a confirmation to the user

[mdtauk]

If we can figure out how to add an Icon when the box is in the Command mode, should it match this?

[0x5bfa]

yep. we can create custom control.

[mdtauk]

Lets keep the icon simple and not too obnoxious. It will probably require a > with a space to enter into the command mode, and switch the visuals of the AddressBar control. Backspacing will exit out of the mode.

[mdtauk]

@yaira2 What is the current status of the Command Palette? I saw mention about adding a button to switch to the commanding mode as well as reading the > input char?